Open
Conversation
Contributor
|
Greatly improves usability! Really well done @mlonn! I would request that you decide on what language the descriptions for environment variables are in, English or Swedish. Technically, we cannot merge this until the changes are approved on the next "sektionsmöte", but I will try to make this happen! |
Dr-Horv
reviewed
Jul 21, 2017
| "name": "VoteIT", | ||
| "description": "A voting system", | ||
| "repository": "https://github.com/cthit/VoteIT", | ||
| "logo": "http://imgur.com/3Xwg8XF.png", |
Contributor
There was a problem hiding this comment.
Perhaps shouldn't refer to logo on imgur? Better to refer to one on GitHub or Chalmers.it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes it possible to deploy app without forking, also requiers user to enter nessecary environment variables.