Feature/tg customer#5
Conversation
Introduce a new Claude runtime implementation and related build/bootstrap artifacts. Adds runtime/claudecode (CLI wrapper, checkpoint/restore, env/config parsing, retries, and unit tests) and wires it into runtime selection. Add Dockerfile.claude, rename Dockerfile -> Dockerfile.openclaw, add bootstrap hooks (bootstrap/claude.sh, bootstrap/openclaw.sh) and dedicated build helpers (docker_build_claude.sh, docker_build_openclaw.sh). Update .env_example, AGENTS.md and readme.md with new env vars, build/run guidance and scripts; remove obsolete docker_build.sh and sandbox-profile.sh. Small server/tests/scripts tweaks and permission/entrypoint adjustments for the new runtime images.
cryptowizard0
left a comment
cryptowizard0
left a comment
There was a problem hiding this comment.
Thanks for the PR. The overall direction is clear: split image flavors, add runtime-specific bootstrap hooks, and introduce Claude / TelegramCustomer runtimes. I found two merge-blocking issues that should be fixed before this can be reviewed as a runnable change.
Also please clarify whether telegramcustomer is intentionally spawn/checkpoint-only. Right now /vmm/apply always returns telegramcustomer apply is not implemented, while the PR adds smoke coverage only for spawn/checkpoint/restore. If callers are expected to use the normal VMM apply path with this runtime, that behavior still needs implementation or documentation as an explicit non-goal.
I did not see CI/status checks on the PR. After the fixes, please run at least go test ./..., ./docker_build_openclaw.sh, ./docker_build_claude.sh, and the TelegramCustomer image build/smoke path in a clean checkout.
| rsc.io/tmplfunc v0.0.3 // indirect | ||
| ) | ||
|
|
||
| replace github.com/xingj404-lab/claude-gw => /Users/sandyzhou/codex-project/claude-gw |
There was a problem hiding this comment.
This committed replace points at a developer-local absolute path, so a clean checkout cannot resolve github.com/xingj404-lab/claude-gw. It also affects the non-Telegram builds because go.mod is copied before the Dockerfile-specific go mod edit steps, so go test ./..., Dockerfile.openclaw, and Dockerfile.claude can fail on any machine that does not have /Users/sandyzhou/codex-project/claude-gw. Please remove this from committed go.mod and keep the local override limited to the TelegramCustomer Docker build context or publish/pin a normal module version.
|
|
||
| COPY --from=builder /app/main /app/main | ||
| COPY start-vmdocker-agent.sh /usr/local/bin/start-vmdocker-agent.sh | ||
| COPY bootstrap/telegramcustomer.sh /usr/local/lib/vmdocker-agent/bootstrap/telegramcustomer.sh |
There was a problem hiding this comment.
This copies bootstrap/telegramcustomer.sh, but that file is not present in the PR. The changed-file list only includes bootstrap/claude.sh and bootstrap/openclaw.sh, so the TelegramCustomer image build will fail at this COPY step. Please add the hook file or adjust the Dockerfile/tests to match the files actually committed.
3 participants
No description provided.