Skip to content

release-windows.yml: fixed build with Visual Studio 2026 [skip ci] #8563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
firewave wants to merge 3 commits into
base: main
Choose a base branch
from
+3 −2
Open

release-windows.yml: fixed build with Visual Studio 2026 [skip ci] #8563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee651db
release-windows.yml: changed solution extension to `slnx` for PCRE [s…
firewave May 19, 2026
6a8efe7
win_installer/config.wxi: updated MergeModule [skip ci]
firewave May 19, 2026
f0099e5
releasenotes.txt: added note about updated compiler for official bina…
firewave May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
cd pcre-%PCRE_VERSION% || exit /b !errorlevel!
git apply --ignore-space-change ..\externals\pcre.patch || exit /b !errorlevel!
cmake . -A x64 -DPCRE_BUILD_PCRECPP=OFF -DPCRE_BUILD_PCREGREP=OFF -DPCRE_BUILD_TESTS=OFF -DCMAKE_POLICY_VERSION_MINIMUM=3.5 -DCMAKE_COMPILE_WARNING_AS_ERROR=On || exit /b !errorlevel!
msbuild -m PCRE.sln -p:Configuration=Release -p:Platform=x64 || exit /b !errorlevel!
msbuild -m PCRE.slnx -p:Configuration=Release -p:Platform=x64 || exit /b !errorlevel!
copy pcre.h ..\externals || exit /b !errorlevel!
copy Release\pcre.lib ..\externals\pcre64.lib || exit /b !errorlevel!

Expand Down
1 change: 1 addition & 0 deletions releasenotes.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,5 @@ Other:
- Make it possible to specify the regular expression engine using the `engine` element in a rule XML.
- Added CLI option `--exitcode-suppress` to specify an error ID which should not result in a non-zero exitcode.
- Moved source code from https://github.com/danmar/cppcheck to https://github.com/cppcheck-opensource/cppcheck
- The official Windows binary is now built with Visual Studio 2026.
-
2 changes: 1 addition & 1 deletion win_installer/config.wxi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@
<?define AddonsDir = "files\addons" ?>
<?define QtDllDir = "files" ?>

<?define CrtMergeModule = "$(env.VCINSTALLDIR)Redist\MSVC\v143\MergeModules\Microsoft_VC143_CRT_x64.msm" ?>
<?define CrtMergeModule = "$(env.VCINSTALLDIR)Redist\MSVC\v145\MergeModules\Microsoft_VC145_CRT_x64.msm" ?>
<?define PlatformProgramFilesFolder = "ProgramFiles64Folder" ?>
</Include>