feat(local): close POSIX/Windows gaps for local stream sockets#252
Open
mvandeberg wants to merge 1 commit into
Open
feat(local): close POSIX/Windows gaps for local stream sockets#252mvandeberg wants to merge 1 commit into
mvandeberg wants to merge 1 commit into
Conversation
Contributor
mvandeberg
commented
May 19, 2026
mvandeberg
commented
- Add Windows make_local_stream_pair() via temp-listener emulation of socketpair(), enabling socket-pair tests on IOCP
- Implement assign_socket() in win_local_stream_service so raw SOCKET handles can be registered with the IOCP port
- Enable local_stream_socket tests on Windows (construction, open, move, connect/accept, read/write, available, release)
- Add portable temp_socket_dir helper using std::filesystem for temp paths across platforms
- Guard local datagram code (SOCK_DGRAM) as POSIX-only at compile time — Windows does not support AF_UNIX SOCK_DGRAM
- Remove dead IOCP datagram implementation files (win_local_dgram_service.hpp, win_local_dgram_socket.hpp)
- Document Windows limitation on local_datagram_socket and local_datagram headers
|
An automated preview of the documentation is available at https://252.corosio.prtest3.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-05-20 17:03:28 UTC |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #252 +/- ##
========================================
Coverage 77.76% 77.76%
========================================
Files 96 96
Lines 7264 7264
Branches 1775 1775
========================================
Hits 5649 5649
Misses 1104 1104
Partials 511 511
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
mvandeberg
force-pushed
the
pr/windows-local-socket-parity
branch
from
d852a7a to
c25be62
Compare
|
GCOVR code coverage report https://252.corosio.prtest3.cppalliance.org/gcovr/index.html Build time: 2026-05-20 17:11:34 UTC |
- Add Windows make_local_stream_pair() via temp-listener emulation of socketpair(), enabling socket-pair tests on IOCP - Implement assign_socket() in win_local_stream_service so raw SOCKET handles can be registered with the IOCP port - Replace ConnectEx/AcceptEx with blocking connect()/accept() on worker threads for AF_UNIX — the IOCP extension functions are not reliable for AF_UNIX on all Windows versions - Enable local_stream_socket tests on Windows (construction, open, move, connect/accept, read/write, available, release) - Add portable temp_socket_dir helper using std::filesystem for temp paths across platforms - Guard local datagram code (SOCK_DGRAM) as POSIX-only at compile time — Windows does not support AF_UNIX SOCK_DGRAM - Remove dead IOCP datagram implementation files (win_local_dgram_service.hpp, win_local_dgram_socket.hpp) - Document Windows limitation on local_datagram_socket and local_datagram headers
mvandeberg
force-pushed
the
pr/windows-local-socket-parity
branch
from
c25be62 to
d57e9f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.