Skip to content

Fix #117: Remove Conan from Dev Container (unused?)#152

Merged
lefticus merged 2 commits into
cpp-best-practices:mainfrom
leftibot:fix/issue-117-remove-conan-from-dev-container-unused
May 2, 2026
Merged

Fix #117: Remove Conan from Dev Container (unused?)#152
lefticus merged 2 commits into
cpp-best-practices:mainfrom
leftibot:fix/issue-117-remove-conan-from-dev-container-unused

Conversation

@leftibot
Copy link
Copy Markdown
Contributor

@leftibot leftibot commented May 2, 2026

Automated fix by @leftibot.

What changed

Fix #117: remove unused Conan install from dev container
Conan was installed in .devcontainer/Dockerfile but never used; the
project manages its dependencies via CPM (see Dependencies.cmake), so
the pip install conan step and the CONAN_SYSREQUIRES_* environment
variables were dead weight on every dev container build. Drop them, and
add a CTest regression test that scans the Dockerfile to prevent Conan
from being reintroduced.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

Files

 .devcontainer/Dockerfile                  | 14 --------------
 test/CMakeLists.txt                       |  6 ++++++
 test/check_no_conan_in_devcontainer.cmake | 19 +++++++++++++++++++
 3 files changed, 25 insertions(+), 14 deletions(-)

Closes #117

Triggered by @lefticus.

…ainer

Conan was installed in `.devcontainer/Dockerfile` but never used; the
project manages its dependencies via CPM (see Dependencies.cmake), so
the `pip install conan` step and the `CONAN_SYSREQUIRES_*` environment
variables were dead weight on every dev container build. Drop them, and
add a CTest regression test that scans the Dockerfile to prevent Conan
from being reintroduced.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 20.50%. Comparing base (ec01c73) to head (c13d505).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #152   +/-   ##
=======================================
  Coverage   20.50%   20.50%           
=======================================
  Files           5        5           
  Lines         239      239           
  Branches      111      132   +21     
=======================================
  Hits           49       49           
+ Misses        186      154   -32     
- Partials        4       36   +32     
Flag Coverage Δ
Linux 18.36% <ø> (ø)
Windows 21.02% <ø> (ø)
macOS 18.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lefticus
Copy link
Copy Markdown
Member

lefticus commented May 2, 2026

@leftibot remove checks for the removal of Conan

Requested by @lefticus in PR cpp-best-practices#152 review.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@leftibot
Copy link
Copy Markdown
Contributor Author

leftibot commented May 2, 2026

Addressed review feedback from @lefticus. New commits:

c13d505 Address review: remove devcontainer Conan-removal regression test

@lefticus lefticus merged commit 25dde07 into cpp-best-practices:main May 2, 2026
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Conan from Dev Container (unused?)

2 participants