fix(AngleTool): fixed bug that was preventing text box to handle for 0 deg angle#1570
Open
ViniciusResende wants to merge 2 commits intocornerstonejs:masterfrom
Open
Conversation
…0 deg angle Previously when creating an angle or even after setting it, we would observe a problem that, when the angle had exactly 0 dregrees, it would not have the textbox rendered.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1570 +/- ##
==========================================
+ Coverage 23.86% 24.45% +0.59%
==========================================
Files 287 287
Lines 10141 10145 +4
Branches 2082 2085 +3
==========================================
+ Hits 2420 2481 +61
+ Misses 6575 6529 -46
+ Partials 1146 1135 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@ViniciusResende could you replicate this issue using ohif v2 and cstools? |
Contributor
Author
|
@igoroctaviano yes, I could replicate both the error and the fix on OHIF v2. Although is not easy to replicate it, since the angle have to be exactly 0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR contains a bug fix. (Reproducible on OHIF V3 and V2)
What is the current behavior? (You can also link to an open issue here)
The current behavior is that, if you create a Angle on OHIF currently, if this angle has exactly 0 degrees the text label will not be rendered.
What is the new behavior (if this is a feature change)?
Now the 0° label is shown.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
This PR shouldn't introduce any breaking change.
Other information: