fix: undefined points in touch events#1517
Open
slak44 wants to merge 2 commits intocornerstonejs:masterfrom
Open
fix: undefined points in touch events#1517slak44 wants to merge 2 commits intocornerstonejs:masterfrom
slak44 wants to merge 2 commits intocornerstonejs:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1517 +/- ##
==========================================
- Coverage 21.70% 21.69% -0.01%
==========================================
Files 287 287
Lines 10137 10139 +2
Branches 2081 2082 +1
==========================================
Hits 2200 2200
- Misses 6750 6751 +1
- Partials 1187 1188 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix.
Currently, there are several situations where undefined point objects are used in touch event handlers:
Check that all these objects are defined, so the tools don't end up accessing properties on undefined. There was already one such check in panend, but the same problem shows up in a few places.
No.
Found the issues by using the tools in OHIF.