feat: add notification/toast system for error feedback#14
Merged
Conversation
Add user-facing error handling UI that was missing in bindx compared to the original Contember binding. The implementation adds three layers: - NotificationStore (core): framework-agnostic store with subscriber pattern, auto-dismiss timers, and deduplication - React hooks: useNotifications, useShowNotification, useDismissNotification, and usePersistWithFeedback (wraps usePersist with automatic toasts) - UI components: ToastContainer/ToastItem for toast display, ErrorOverlay for critical load errors, BindxErrorBoundary for React error boundaries PersistButton now uses usePersistWithFeedback for automatic feedback on save (success/error/validation warning toasts).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NotificationStoreto@contember/bindxcore – framework-agnostic store with subscriber pattern, auto-dismiss timers (error=60s, warning=15s, success=6s), and deduplicationuseNotifications,useShowNotification,useDismissNotification,usePersistWithFeedback) to@contember/bindx-reactToastContainer/ToastItemcomponents,ErrorOverlayfor critical load errors, andBindxErrorBoundaryto@contember/bindx-uiPersistButtonnow automatically shows success/error/warning toasts viausePersistWithFeedbackMirrors the error handling UX from the original Contember binding (full-screen overlay for load errors, toast notifications for persist results). Field-level errors already worked via
FormContainer→FormError.Usage
Test plan
bun run typecheckpassesbun run buildpassesNotificationStore(add, dismiss, clear, dedup, subscribe, destroy)bun run playground)