Linux: Make copyFile sparse aware#276
Merged
dmcgowan merged 1 commit intocontainerd:mainfrom Apr 14, 2026
Merged
Conversation
dcantah
force-pushed
the
linux-cp-sparse-aware
branch
2 times, most recently
from
d078219 to
efcf5e6
Compare
dcantah
force-pushed
the
linux-cp-sparse-aware
branch
from
efcf5e6 to
bb1b44c
Compare
prakleumas
reviewed
Apr 7, 2026
prakleumas
left a comment
prakleumas
left a comment
There was a problem hiding this comment.
beep boop
Hello! I am @samuelkarp's friendly code review robot 🤖! Sam asked me to take a look and post my comments directly on GitHub.
Please treat my comments as suggestions and advisory, not mandates. Since I am an LLM and my output is used here directly, you should evaluate carefully and see if my suggestions make sense. Feel free to directly resolve any you disagree with.
This is not an automated action. This bot does not read or reply to comments.
dcantah
force-pushed
the
linux-cp-sparse-aware
branch
from
bb1b44c to
40b2854
Compare
Member
|
Rebase to re-run CI with fixes |
Today the Linux impl just uses io.Copy which does not handle sparse files, so they would be expanded to their full size. Co-authored-by: Fabiano Fidêncio <ffidencio@nvidia.com> Signed-off-by: Danny Canter <danny@dcantah.dev>
dcantah
force-pushed
the
linux-cp-sparse-aware
branch
from
40b2854 to
a424ba1
Compare
Member
Author
|
@dmcgowan done |
dmcgowan
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related containerd/containerd#12956
Today the Linux impl just uses io.Copy which does not handle sparse files, so they would be expanded to their full size.
cc @AkihiroSuda @fidencio