refactor: remove NodeHttpAdapter in favor of @constructive-io/fetch#1152
Merged
Conversation
The ORM client's FetchAdapter already uses createFetch() from
@constructive-io/fetch, which handles *.localhost DNS rewriting and
Host header preservation in Node.js. The separate NodeHttpAdapter
(using node:http/node:https directly) is redundant.
- Remove node-fetch.ts template and all generated node-fetch.ts files
- Remove generateNodeFetchFile() from utils-generator
- Simplify executor generators to always use { endpoint, headers }
- Remove nodeHttpAdapter config plumbing from generate.ts
- Deprecate nodeHttpAdapter option in config types
- Update all 4 SDK executor.ts files to use endpoint/headers
The external API (createClient, getClient) is unchanged — consumers
pass endpoint + headers, and FetchAdapter handles the rest.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the redundant
NodeHttpAdapter(which usednode:http/node:httpsdirectly) from codegen and all generated SDKs. The ORM'sFetchAdapteralready usescreateFetch()from@constructive-io/fetch, which handles*.localhostDNS rewriting and Host header preservation in Node.js automatically.What changed:
node-fetch.tstemplate and all 8 generatednode-fetch.tsfilesgenerateNodeFetchFile()from codegen utils{ endpoint, headers }—FetchAdapterhandles the restnodeHttpAdapteroption fromExecutorOptions,GenerateMultiTargetCliOptions, config types, andgenerateCreateClientFilegenerate.tsexecutor.tsfilesExternal API unchanged — consumers still pass
endpoint+headerstocreateClient.Net: -1,766 lines.
Review & Testing Checklist for Human
createClient({ endpoint, headers })works with*.localhostendpoints (e.g.auth.localhost:3000/graphql) —FetchAdapterhandles DNS + Host header via@constructive-io/fetchcnc codegenon a project and confirm nonode-fetch.tsfiles appear incli/ororm/outputexecutor.tsuses{ endpoint, headers }instead ofnew NodeHttpAdapter(...)graphql/orm-testsuite (which runs codegen dynamically against a live PG) is the best integration test for this — it exercisesrunCodegenAndLoadend-to-endNotes
FindManyArgstemplate still hasTOrderBy = never— can be a separate follow-upLink to Devin session: https://app.devin.ai/sessions/7d04ac62fc67430aba0aaa40e044eb14
Requested by: @pyramation