Skip to content

Update buildkit to v0.28.1#3219

Open
Elijah-Destigni wants to merge 4 commits intoconforma:mainfrom
Elijah-Destigni:eli/dep-bump
Open

Update buildkit to v0.28.1#3219
Elijah-Destigni wants to merge 4 commits intoconforma:mainfrom
Elijah-Destigni:eli/dep-bump

Conversation

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8d10283b-2ba3-4296-978a-2b3db1caf9f4

📥 Commits

Reviewing files that changed from the base of the PR and between f361ef6 and f267e3c.

📒 Files selected for processing (1)
  • .tool-versions
✅ Files skipped from review due to trivial changes (1)
  • .tool-versions

📝 Walkthrough

Walkthrough

Updated Go toolchain directives from 1.25.3 to 1.25.5 across multiple modules and bumped numerous direct and indirect dependency versions; no source code logic or exported APIs were changed.

Changes

Cohort / File(s) Summary
Root module
go.mod
Bumped go directive to 1.25.5 and updated multiple direct/indirect dependencies (AWS SDK v2 modules, containerd, docker/moby, github.com/spdx/tools-golang, golang.org/x/*, theupdateframework/go-tuf/v2, etc.).
Tools module (large transitive refresh)
tools/go.mod
Updated go directive to 1.25.5 and performed a broad refresh of transitive deps: added/removed/updated many toolchain and tooling libraries (cloud SDKs, sigstore, go-openapi, compression/hashing libs, kube/auth, misc). High churn in indirect requirements.
Acceptance module
acceptance/go.mod
Only updated go directive from 1.25.3 to 1.25.5; no dependency list changes.
Tools kubectl module
tools/kubectl/go.mod
Only updated go directive from 1.25.3 to 1.25.5; no dependency list changes.
Build image config
Dockerfile, Dockerfile.dist
Updated build-stage base images to Go 1.25.5 (docker.io/library/golang:1.25.5 and registry.access.redhat.com/ubi9/go-toolset:1.25.5 with new digest). No other Dockerfile logic changed.
Toolchain file
.tool-versions
Updated pinned Go toolchain from golang 1.25.3 to golang 1.25.5.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title claims to update buildkit to v0.28.1, but the changeset only updates Go versions (1.25.3 to 1.25.5) and dependencies in go.mod files, with no buildkit version change visible. Update the title to accurately reflect the main changes, such as 'Update Go version to 1.25.5 and refresh dependencies' or 'Bump Go toolchain to 1.25.5 across modules'.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess whether it relates to the changeset. Add a pull request description explaining the purpose of the Go version bump and dependency updates to help reviewers understand the rationale and scope.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@qodo-code-review
Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Update buildkit to v0.28.1 and bump Go dependencies

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Update Go version from 1.25.3 to 1.25.5
• Upgrade buildkit from v0.26.3 to v0.28.1
• Update multiple indirect dependencies for security and compatibility
• Bump AWS SDK, containerd, Docker, and other core dependencies
Diagram
flowchart LR
  A["Go 1.25.3"] -->|upgrade| B["Go 1.25.5"]
  C["buildkit v0.26.3"] -->|upgrade| D["buildkit v0.28.1"]
  E["Multiple dependencies"] -->|update| F["Latest compatible versions"]
  D --> G["Updated go.mod"]
  F --> G
  G --> H["Updated go.sum"]
Loading

Grey Divider

File Changes

1. go.mod Dependencies +36/-36

Dependency version updates and buildkit upgrade

• Updated Go version from 1.25.3 to 1.25.5
• Upgraded github.com/moby/buildkit from v0.26.3 to v0.28.1
• Updated github.com/spdx/tools-golang from v0.5.5 to v0.5.7
• Bumped golang.org/x/net from v0.49.0 to v0.51.0
• Updated golang.org/x/text from v0.33.0 to v0.34.0
• Updated multiple AWS SDK v2 packages to latest versions
• Upgraded containerd, Docker, and related dependencies
• Updated golang.org/x/crypto, golang.org/x/mod, golang.org/x/term, golang.org/x/tools

go.mod


2. go.sum Dependencies +72/-76

Checksum updates for all dependency upgrades

• Updated checksums for Go 1.25.5 and buildkit v0.28.1
• Removed old checksum entries for github.com/anchore/go-struct-converter
 v0.0.0-20230627203149-c72ef8859ca9
• Added new checksum for github.com/anchore/go-struct-converter v0.1.0
• Updated checksums for all bumped AWS SDK v2 packages
• Updated checksums for containerd, Docker, and related packages
• Updated checksums for golang.org packages (crypto, mod, net, term, text, tools)
• Removed obsolete checksum entry for sigs.k8s.io/yaml v1.4.0

go.sum


Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Copy Markdown
Contributor

Code Review by Qodo

Grey Divider

Looking for bugs?

Check back in a few minutes. An AI review agent is analyzing this pull request.

Grey Divider

Qodo Logo

@joejstuart
Copy link
Copy Markdown
Contributor

Thanks for the PR!

I'm not sure how important it is, but we usually try and keep the golang version the same across all go.mod files. Would you mind updating the rest to 1.25.5?

./go.mod
./tools/go.mod
./tools/kubectl/go.mod
./acceptance/go.mod

module github.com/conforma/cli

go 1.25.3
go 1.25.5
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we update golang we have to also update the builder base image in two dockerfiles.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I can push a commit on top of this to do that.

Also update go version in all go.mod files so it's consistently
1.25.5.
@github-actions github-actions bot added size: XXL and removed size: L labels Apr 2, 2026
@simonbaird
Copy link
Copy Markdown
Member

Thanks for the PR!

I'm not sure how important it is, but we usually try and keep the golang version the same across all go.mod files. Would you mind updating the rest to 1.25.5?

./go.mod
./tools/go.mod
./tools/kubectl/go.mod
./acceptance/go.mod

Oh I did this also. 👍

@simonbaird
Copy link
Copy Markdown
Member

You should be able to reproduce the test failure locally with this:

make test

Something to do with undefined: archive.Compression in one of the docker modules I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants