Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughUpdated Go toolchain directives from 1.25.3 to 1.25.5 across multiple modules and bumped numerous direct and indirect dependency versions; no source code logic or exported APIs were changed. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review Summary by QodoUpdate buildkit to v0.28.1 and bump Go dependencies
WalkthroughsDescription• Update Go version from 1.25.3 to 1.25.5 • Upgrade buildkit from v0.26.3 to v0.28.1 • Update multiple indirect dependencies for security and compatibility • Bump AWS SDK, containerd, Docker, and other core dependencies Diagramflowchart LR
A["Go 1.25.3"] -->|upgrade| B["Go 1.25.5"]
C["buildkit v0.26.3"] -->|upgrade| D["buildkit v0.28.1"]
E["Multiple dependencies"] -->|update| F["Latest compatible versions"]
D --> G["Updated go.mod"]
F --> G
G --> H["Updated go.sum"]
File Changes1. go.mod
|
|
Thanks for the PR! I'm not sure how important it is, but we usually try and keep the golang version the same across all |
| module github.com/conforma/cli | ||
|
|
||
| go 1.25.3 | ||
| go 1.25.5 |
There was a problem hiding this comment.
When we update golang we have to also update the builder base image in two dockerfiles.
There was a problem hiding this comment.
Actually I can push a commit on top of this to do that.
Also update go version in all go.mod files so it's consistently 1.25.5.
Oh I did this also. 👍 |
|
You should be able to reproduce the test failure locally with this: Something to do with |

https://redhat.atlassian.net/issues?jql=project%20in%20(%22Trusted%20Artifact%20Signer%22)%0Aand%20issuetype%20%3D%20Vulnerability%0Aand%20status%20not%20in%20(Closed%2C%20%22Release%20Pending%22)%0Aand%20affectedVersion%20%3D%201.3.0%0AORDER%20BY%20due%20DESC&selectedIssue=SECURESIGN-4078