This repository was archived by the owner on Feb 20, 2024. It is now read-only.
cp-kafka-connect: deploymentStrategy#647
Open
Christos Kotsis (ulfox) wants to merge 1 commit intoconfluentinc:masterfrom
Open
cp-kafka-connect: deploymentStrategy#647Christos Kotsis (ulfox) wants to merge 1 commit intoconfluentinc:masterfrom
Christos Kotsis (ulfox) wants to merge 1 commit intoconfluentinc:masterfrom
Conversation
Allow setting the deployment startegy for the deployment For example allow setting a RollingUpdate stategy.
Christos Kotsis (ulfox)
requested review from
Shankar Hiremath (shiremath) and
Zhaochun Ma (zhaochun-ma)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Allow setting the deployment startegy for the deployment
For example allow setting a RollingUpdate stategy.
Additional notes:
Currently, when we make a change to the deployment, all workers will get re-created at the same time.
With this addition, a change on the deployment, will not re-create all the workers at the same time, but in
a rolling restart way.
How was this patch tested?
Locally using minikube