Skip to content

PDJB-713: Update task list rows to match copy#1292

Open
samyou-softwire wants to merge 2 commits intomainfrom
fix/PDJB-713-use-simplied-tasklist-headings
Open

PDJB-713: Update task list rows to match copy#1292
samyou-softwire wants to merge 2 commits intomainfrom
fix/PDJB-713-use-simplied-tasklist-headings

Conversation

@samyou-softwire
Copy link
Copy Markdown

@samyou-softwire samyou-softwire commented May 5, 2026

Ticket number

PDJB-713

Goal of change

update task list page to be simpler

Description of main change(s)

updates copy strings
removes now unneeded copy

Screenshots

task list with updated copy

Checklist

Delete any that are not applicable, and add explanation below for any that are applicable but haven't been done

  • Screenshots of any UI changes have been added
  • Unit tests for new logic (e.g. new service methods) have been added
  • Test suite has been run in full locally and is passing
  • Branch has been rebased onto main and run locally, with everything working as expected (both for your new feature
    and any related functionality)
  • TODO comments referencing this JIRA ticket have been searched for and removed - if a future PR will address them,
    mention that here
  • QA instructions have been added to the ticket (particularly if this is the last PR required to complete the ticket)

@samyou-softwire samyou-softwire self-assigned this May 5, 2026
@samyou-softwire samyou-softwire force-pushed the fix/PDJB-713-use-simplied-tasklist-headings branch from 7a4a632 to f5f4323 Compare May 6, 2026 10:33
@samyou-softwire samyou-softwire marked this pull request as ready for review May 6, 2026 10:49
Copy link
Copy Markdown
Collaborator

@Travis-Softwire Travis-Softwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Contributor

@TomHanmer29 TomHanmer29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One small comment

// Address lookup - render page
assertThat(addressLookupPage.form.fieldsetHeading).containsText("What is the property address?")
assertThat(addressLookupPage.form.sectionHeader).containsText("Section 1 of 2 — Register your property details")
assertThat(addressLookupPage.form.sectionHeader).containsText("Section 1 of 2 — Add property details")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to your change really, but I wonder if it's worth extracting this out into a constant somewhere given we use it so much (e.g. propertyRegistrationSectionHeader or something similar)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants