Skip to content

fix: correct outline active heading detection and scroll-to-center on click #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
octo-patch wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: correct outline active heading detection and scroll-to-center on click #1070

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/app/core/main/editor/markdown/outline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,8 +229,9 @@ export function Outline({
const scrollTop = editorElement.scrollTop
const viewportTop = scrollTop + 100 // Add some offset for better UX

// Find the first heading that is above or near the viewport top
for (const heading of headings) {
// Find the last heading that is above or near the viewport top (iterate in reverse)
for (let i = headings.length - 1; i >= 0; i--) {
const heading = headings[i]
const domNode = editor.view.nodeDOM(heading.pos) as HTMLElement | undefined
if (domNode) {
const rect = domNode.getBoundingClientRect()
Expand Down Expand Up @@ -296,10 +297,15 @@ export function Outline({
// Then set the selection to the heading position
editor.commands.setTextSelection(targetPos)

// Then scroll into view
// Then scroll into view, centering the heading in the editor
// Use setTimeout to ensure the selection is applied first
setTimeout(() => {
editor.commands.scrollIntoView()
const domNode = editor.view.nodeDOM(targetPos) as HTMLElement | undefined
if (domNode) {
domNode.scrollIntoView({ behavior: 'smooth', block: 'center' })
} else {
editor.commands.scrollIntoView()
}
}, 0)

onHeadingSelect?.()
Expand Down