Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1667 +/- ##
==========================================
- Coverage 54.67% 54.16% -0.51%
==========================================
Files 336 340 +4
Lines 27448 27781 +333
==========================================
+ Hits 15006 15048 +42
- Misses 12442 12733 +291
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Also, there should be some documentation of the controller communication format. Also, i'm not sure i like the name: i think it'd be more descriptive to call this something like "DynamicInteractive" to emphasize that it spawns solutions dynamically. (and then Communication could be renamed to Interactive, which is what it really is. though we'd probably need to keep the name Communication as an alias.) |
The plan is to have Interactive eventually also take over the tasks that we currently do with Communication, so I am happy with the "Interactive" task name. As for documentation: that will come, I would like first to make sure that we agree the implementation is sensible. |
prandla
left a comment
There was a problem hiding this comment.
i think the implementation in general is fine now. interactive_keeper.py doesn't really spark joy for me, but i don't know how to improve it much. (aside from the one comment i left in it)
33aad96 to
5060e23
Compare
No description provided.