fix: clarify Save button location in Versions & Deployments docs#29923
fix: clarify Save button location in Versions & Deployments docs#29923nanookclaw wants to merge 4 commits into
Conversation
The Save button is only visible within the Online Editor (Edit Code) interface, not on the main Worker dashboard or Deployments tab. This updates the instructions to specify navigating to Edit Code first. Closes cloudflare#28812
codyanthony850
left a comment
There was a problem hiding this comment.
Pre-existing issue on this page: the links to /workers/wrangler/commands/general/#versions-upload and #versions-deploy point to a page where those anchors no longer exist. The command reference moved to /workers/wrangler/commands/workers/. I'll fix these separately.
| ::: | ||
|
|
||
| To create a new version of your Worker that is not deployed immediately, use the [`wrangler versions upload`](/workers/wrangler/commands/general/#versions-upload) command or create a new version via the Cloudflare dashboard using the **Save** button. You can find the **Save** option under the down arrow beside the "Deploy" button. | ||
| To create a new version of your Worker that is not deployed immediately, use the [`wrangler versions upload`](/workers/wrangler/commands/general/#versions-upload) command or create a new version via the Online Editor in the Cloudflare dashboard by clicking **Edit Code**, then selecting the **Save** option under the down arrow beside the "Deploy" button. |
There was a problem hiding this comment.
The gradual deployments page (step 3, "Via the Cloudflare dashboard") uses "online code editor":
| To create a new version of your Worker that is not deployed immediately, use the [`wrangler versions upload`](/workers/wrangler/commands/general/#versions-upload) command or create a new version via the Online Editor in the Cloudflare dashboard by clicking **Edit Code**, then selecting the **Save** option under the down arrow beside the "Deploy" button. | |
| To create a new version of your Worker that is not deployed immediately, use the [`wrangler versions upload`](/workers/wrangler/commands/general/#versions-upload) command or create a new version via the online code editor in the Cloudflare dashboard by selecting **Edit code**, then selecting the **Save** option under the down arrow beside the "Deploy" button. |
|
This paragraph now describes two different workflows (CLI and dashboard) in one sentence, and the dashboard path is a multi-step procedure. Consider splitting into tabs with numbered steps: <Tabs> <TabItem label="Wrangler CLI">
To create a new version of your Worker that is not deployed immediately:
1. Run [`wrangler versions upload`](/workers/wrangler/commands/general/#versions-upload).
</TabItem> <TabItem label="Dashboard">
To create a new version of your Worker that is not deployed immediately:
1. Go to **Workers & Pages** and select your Worker.
2. Select **Edit code** to open the online code editor.
3. Select the down arrow next to **Deploy** > **Save**.
</TabItem> </Tabs>Not required for this PR. If you'd rather keep the scope to the naming fix, I can do this in a follow-up. |
|
Split into Wrangler CLI / Dashboard tabs with numbered steps per your suggestion (93d6e27). The dashboard path now walks through the full flow: Edit Code → down arrow → Save → Deployments tab. |
|
Addressed the feedback in 3c089be — split the paragraph into Wrangler CLI / Dashboard tabs with numbered steps for the dashboard path. The broken anchor links (versions-upload, versions-deploy) are noted as pre-existing and out of scope for this PR. |
Replace tabbed interface with simpler prose using 'online code editor' terminology consistent with the gradual deployments page.
nanookclaw
left a comment
There was a problem hiding this comment.
Applied the suggestion — replaced the tabbed interface with prose using "online code editor" to match the gradual deployments page. Thanks for catching the consistency issue.
MattieTK
left a comment
There was a problem hiding this comment.
thanks for the clarification 😁
Description
Clarifies the location of the Save button for creating new Worker versions in the Versions & Deployments documentation.
The Save button is only visible within the Online Editor (Edit Code) interface, not on the main Worker dashboard or Deployments tab. The previous instructions did not specify this, making it difficult for users to find the button.
Changes
Related
Closes #28812