You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Mistral errors if an assistant message includes both content and tool_calls so this adds a check for it.
Mistral also errors if a tool call does not include tool_call_id, so this includes it.
Add a model setting sequentialCalls, so a model is allowed to chain tool calls together, instead of only when the last message is a user message. This makes all responses be a simulated stream.
Hey @deathbyknowledge, thanks for this! I've got a couple of questions.
If this is fixing something that breaks normal usage, then is it the right way to go to hide the functionality behind a model setting? I'm worried here that no-one will discover this setting and just assume that the model is broken.
Would you be able to add some example JSON objects to the description to explain exactly what the issue is here, because I'm interested to see if there's a general solution.
Is this an issue that is just for Mistral? And if so, is it the job of the workers-ai-provider to fix it, or is it a model output issue?
I think generally I'm missing some context that defines the exact problem that we have here. And it would be good to detail it for posterity.
revisiting this, I'd like to land support for mistral, can we address feedback and move forward here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contentandtool_callsso this adds a check for it.tool_call_id, so this includes it.sequentialCalls, so a model is allowed to chain tool calls together, instead of only when the last message is a user message. This makes all responses be a simulated stream.Usage: