fix(shell): wrap git fs adapter unlink with fsError for proper ENOENT code#1249
Merged
threepointone merged 1 commit intocloudflare:mainfrom Apr 4, 2026
Merged
Conversation
… code isomorphic-git's FileSystem.rm() catches errors with err.code === 'ENOENT' to silently ignore missing files. The Workspace filesystem throws errors without a .code property, so unlink on a missing file (e.g. .git/shallow during non-shallow clone) propagated as an unhandled error. Wrap unlink with the existing fsError() helper, matching the pattern already used by readFile, stat, lstat, and readlink in the same file.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
agents
@cloudflare/ai-chat
@cloudflare/codemode
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… code
isomorphic-git's FileSystem.rm() catches errors with err.code === 'ENOENT' to silently ignore missing files. The Workspace filesystem throws errors without a .code property, so unlink on a missing file (e.g. .git/shallow during non-shallow clone) propagated as an unhandled error.
Wrap unlink with the existing fsError() helper, matching the pattern already used by readFile, stat, lstat, and readlink in the same file.