Skips retrying on "command not found" errors#410
Open
claudiubelu wants to merge 1 commit intocloudbase:masterfrom
Open
Skips retrying on "command not found" errors#410claudiubelu wants to merge 1 commit intocloudbase:masterfrom
claudiubelu wants to merge 1 commit intocloudbase:masterfrom
Conversation
`exec_ssh_cmd` will retry the given cmd in case an error occurs. But if the command does not exist, there's no need to retry.
Dany9966
requested changes
Apr 15, 2026
| std_out.decode(errors='ignore'), | ||
| std_err.decode(errors='ignore'))) | ||
| (cmd, remote_str, exit_code, stdout_str, stderr_str)) | ||
| if ("command not found" in stdout_str or |
Contributor
There was a problem hiding this comment.
I think it might be better to check exit_code == 127 instead of reliying on the stdout/stderr output. What if something outputs that exact message?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exec_ssh_cmdwill retry the given cmd in case an error occurs. But if the command does not exist, there's no need to retry.