Reconcile NPC names#83
Merged
cliffe merged 3 commits intocliffe:mainfrom May 8, 2026
Merged
Conversation
Contributor
Author
|
I realised there are also inconsistencies in scenario 2 with Dr Bashir needing to be fully renamed to Priya Sharma so I will complete this first. Also need to fix issue where this npc doesn't appear after all task completions and I can't trigger the debrief / scenario completion. |
Owner
|
Ok -- let me know once it's ready to merge |
Contributor
Author
|
Ready to merge now. Renamed Dr Bashir to Priya Sharma throughout. Fixed spawn issue: facility_safe_state and priya_sharma_visible are now set directly from Tom Hadley's Ink, bypassing the conditions which were silently failing due to the evaluator not supporting globalVars.* syntax. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two NPCs were renamed in their game scenarios to resolve accidental cross-scenario name overlaps. This PR updates all source files (ink dialogue, scenario config, documentation) so that display names are consistent throughout. NPC id fields are intentionally left unchanged to preserve audio cache resolution.
SIS02 Energy — SCADA Engineer renamed from Priya Chandra → Helen Marsh. Updated across scenario.json.erb, npc_helen_marsh.ink (renamed from npc_priya_chandra.ink), npc_marcus_webb.ink, information_pack.md, TESTING_WALKTHROUGH.md, TODO.md, VALIDATION_SUMMARY.md, and INK_DEVELOPMENT_SUMMARY.md. Variable/task-id renames (priya_briefed → helen_briefed, talk_to_priya → talk_to_helen) coordinated between the ink file and scenario.json.erb. Dr Priya Sharma (NCSC inspector) references are untouched.
SIS03 Cyber Insurance — Loss adjuster renamed from David Osei → Simon Hartley. The in-game implementation already used Simon Hartley; this commit updates information_pack.md (11 occurrences) and VALIDATION_SUMMARY.md (1 occurrence) to match. The osei_report_envelope object ID is intentionally left unchanged.