Skip to content

fix: invalid client on init#341

Merged
calvinbrewer merged 1 commit intomainfrom
cli-fix
Apr 11, 2026
Merged

fix: invalid client on init#341
calvinbrewer merged 1 commit intomainfrom
cli-fix

Conversation

@calvinbrewer
Copy link
Copy Markdown
Contributor

@calvinbrewer calvinbrewer commented Apr 11, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an invalid client error in the CLI authentication process.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 11, 2026

🦋 Changeset detected

Latest commit: 0d21e9b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cipherstash/cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@calvinbrewer calvinbrewer merged commit 6f63aea into main Apr 11, 2026
3 of 4 checks passed
@calvinbrewer calvinbrewer deleted the cli-fix branch April 11, 2026 16:23
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 11, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 18ffea17-0963-45f8-9e94-b9799710812b

📥 Commits

Reviewing files that changed from the base of the PR and between e968ff9 and 0d21e9b.

📒 Files selected for processing (2)
  • .changeset/petite-cities-lose.md
  • packages/cli/src/commands/auth/login.ts

📝 Walkthrough

Walkthrough

This PR adds a Changeset entry for a minor version bump of @cipherstash/cli and updates the login authentication function to consistently use the 'cli' OAuth client identifier instead of deriving it from the referrer parameter.

Changes

Cohort / File(s) Summary
Changelog Entry
.changeset/petite-cities-lose.md
Adds a Changeset entry documenting a minor version bump for @cipherstash/cli with the note "Fix invalid client error."
Authentication Logic
packages/cli/src/commands/auth/login.ts
Modified the login function to use a constant 'cli' OAuth client_id for device-code flow instead of a dynamic value based on referrer. Renamed the referrer parameter to _referrer to mark it as explicitly unused.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • coderdan

Poem

🐰 Hopping through the auth so neat,
Client IDs now complete,
Fixed the error, all is clear,
CLI's burrow has no fear!

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cli-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant