TypeScript Adoption Plan: get it started 🎉#5
Closed
chriskrycho wants to merge 79 commits intomasterfrom
Closed
Conversation
|
Like I said in Discord, my imagination regarding the documentation is:
These three switches, it seems, would make TS seem pretty first-class in the documentation. It's always there, but it's not in your face. I think the a11y model might be good to follow. Make it accessible by default (though TS isn't default), and reward people who want to do a deeper dive. In this case, make TS an option in the detailed tutorial and then just move on. Ideally the code snippets would all be written in TS and then the JS version would be compiled from it, like with the proposed blueprints. This means not having to maintain two versions of each code snippet. |
Owner
Author
|
@muziejus I believe all of that is covered in the RFC. :) |
|
Super. Can't wait to contribute to the documentation. |
dfreeman
reviewed
Feb 23, 2022
dfreeman
left a comment
dfreeman
left a comment
There was a problem hiding this comment.
Thank you so so much for all your hard work on this!
|
|
||
| This does introduce two new small considerations: | ||
|
|
||
| - New APIs will now need to specify import paths for type-only imports. For example, today there is no public import for `Transition` or `RouteInfo`, because they are not intended for end users to construct. However, types for them *should* be publicly exported because end users need to be able to name those types them in their own code. If we were to write [RFC #0095: Router Service](https://emberjs.github.io/rfcs/0095-router-service.html) today, we would specify imports for both. |
Co-authored-by: Dan Freeman <dfreeman@salsify.com>
chriskrycho
commented
Feb 23, 2022
chriskrycho
commented
Feb 23, 2022
chriskrycho
commented
Feb 23, 2022
- Courtesy of @wagenet's work (and in line with the recommended migration path for Ember Classic types *in this RFC*!) the bit about `Controller` ambient types became defunct, and we should in fact be able to rely on Ember’s own types as the full source of truth. - Fix an incomplete sentence/paragraph caught by @dfreeman (on the SemVer option of *not* using `strict: true` but using specific flags).
Owner
Author
|
Opened as emberjs#800! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered draft – now open for comments and input from the TypeScript strike team for polishing before opening against Ember!
Looking for feedback especially on: