ci: use windows 2025 runners#7048
Conversation
acc22ee to
22393f5
Compare
|
So, the Windows globalisation implementation doesn't work on latest windows AND the ICU alternative fails too, weirdly the test runner seems to be crashing out after one of the fails rather than finishing and saying how many tests failed.... that is awkward. A couple of test fails look like things that are may be fairly easily fixable e.g. ICU version mismatches to amend tests for or inconsistent conditions in the test suite that expect windows to not be ICU etc. Hopefully it's not overall too big a job but I have no setup I can work on this on. |
|
I'll look into this in the next view weeks |
22393f5 to
659a32f
Compare
|
The windows-2019 test runners are now disabled.... So all CI runs now fail. |
`windows-2019` → `windows-2022`
efab8ed to
4135302
Compare
4135302 to
18eaa7e
Compare
a240230 to
a931ead
Compare
|
@ppenzin What do you think? This fixes INTL on windows newer than the May 2019 Update but breaks it on older versions - though the key change is just build config we could perhaps document how to build the older version? |
rhuanjl
left a comment
There was a problem hiding this comment.
Thank you for the work on this. Hoping we'll merge it within a week though I have a few questions - see comments.
ppenzin
left a comment
There was a problem hiding this comment.
LGTM; I am fine with either direction on detecting two DLLs vs one - it would be good to detect it, but not sure if additional logic is worthwhile.
windows-2019actions are unsupported as of 30.06.2025.This PR updates the ci-config to run on the supported versions of the windows runner:
windows-2022→windows-2025windows-2019→windows-2022💥 Breaking changes
This config is broken on recent versions of Windows 11 as CC does not initialize WinRT using RoInitialize to allow for some optimizations.
This removes compat of the default config with all windows versions < Version 1903 (May 2019 Update)
Should be fine as Windows 10 is out-of-support anyway...
🧪 Tests
win32 => WinGlob; that is obviously wrong now.The "new" behavior is consistent with recent node.js and bun.js
See actions/runner-images#12045
Fixes #7045
Fixes #4490