fix: make secure cookie settings conditional on dev mode#2939
Merged
migmartri merged 1 commit intochainloop-dev:mainfrom Mar 26, 2026
Merged
fix: make secure cookie settings conditional on dev mode#2939migmartri merged 1 commit intochainloop-dev:mainfrom
migmartri merged 1 commit intochainloop-dev:mainfrom
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="app/controlplane/internal/service/auth.go">
<violation number="1" location="app/controlplane/internal/service/auth.go:450">
P2: Keep `HttpOnly` enabled even in dev mode; only `Secure`/`SameSite` need to be relaxed for non-HTTPS local OAuth flows.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
matiasinsaurralde
approved these changes
Mar 26, 2026
Closes chainloop-dev#2937 Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev> Update app/controlplane/internal/service/auth.go Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> Signed-off-by: Miguel Martinez Trivino <migmartri@gmail.com> update Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
migmartri
force-pushed
the
fix/dev-mode-secure-cookies
branch
from
d4763c1 to
309cf21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HttpOnly,Secure, andSameSitecookie attributes conditional on non-development mode (server.Version != "dev")Closes #2937