Skip to content

post-1.20-release: remove testing for release-1.18#1164

Merged
cert-manager-prow[bot] merged 1 commit intomasterfrom
cleanup-after-1.20-release
Apr 11, 2026
Merged

post-1.20-release: remove testing for release-1.18#1164
cert-manager-prow[bot] merged 1 commit intomasterfrom
cleanup-after-1.20-release

Conversation

@maelvls
Copy link
Copy Markdown
Member

@maelvls maelvls commented Mar 27, 2026

cert-manager 1.18 is no longer supported since the release of 1.20, so removing all the testing configuration, as per the release process:

(final release only) Create a PR on cert-manager/testing, removing any unsupported release versions from prow config.

Changes:

  • Remove release-1.18 from prowgen knownBranches
  • Delete release-1.18 prow job spec and associated periodics
  • Remove release-1.18 branch-protection entry
  • Remove release-1.18 testgrid dashboard
  • Bump cert-manager helm install version to v1.20.1
  • Adjust cron schedules for release-1.19 and release-1.20 periodics; a side-effect of running make prowgen

Part of:

Based on:

Copilot AI review requested due to automatic review settings March 27, 2026 09:42
@cert-manager-prow cert-manager-prow bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 27, 2026
@maelvls maelvls force-pushed the cleanup-after-1.20-release branch from 2f2ca28 to b6fed07 Compare March 27, 2026 09:43
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Mar 27, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates cert-manager’s Prow job generation/config to drop testing for older cert-manager/Kubernetes versions as part of the post-v1.20 release process, including removing the release-1.18 branch from prowgen and updating generated jobs to stop targeting Kubernetes 1.31/1.32.

Changes:

  • Remove the release-1.18 BranchSpec from prowgen branch definitions.
  • Update generated presubmit/periodic job matrices for master, release-1.19, and release-1.20 to use Kubernetes 1.33–1.35 (and adjust crons accordingly).
  • Regenerate job YAMLs reflecting the updated Kubernetes version targets.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 10 comments.

File Description
config/prowgen/prowspecs/specs.go Removes release-1.18 branch spec and updates Kubernetes version matrices for remaining branches.
config/jobs/cert-manager/cert-manager/master/cert-manager-master.yaml Updates master presubmit/periodic jobs to Kubernetes 1.33–1.35 and adjusts schedules.
config/jobs/cert-manager/cert-manager/release-1.19/cert-manager-release-1.19.yaml Updates release-1.19 presubmit/periodic jobs to Kubernetes 1.33–1.35 and adjusts schedules.
config/jobs/cert-manager/cert-manager/release-1.20/cert-manager-release-1.20.yaml Updates release-1.20 presubmit/periodic jobs to Kubernetes 1.33–1.35 and adjusts schedules.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread config/prowgen/prowspecs/specs.go
Comment thread config/prowgen/prowspecs/specs.go
Comment thread config/jobs/cert-manager/cert-manager/master/cert-manager-master.yaml Outdated
Comment thread config/jobs/cert-manager/cert-manager/release-1.20/cert-manager-release-1.20.yaml Outdated
Comment thread config/prowgen/prowspecs/specs.go
Comment thread config/jobs/cert-manager/cert-manager/release-1.19/cert-manager-release-1.19.yaml Outdated
Comment thread config/jobs/cert-manager/cert-manager/release-1.19/cert-manager-release-1.19.yaml Outdated
Comment thread config/prowgen/prowspecs/specs.go
@maelvls maelvls force-pushed the cleanup-after-1.20-release branch from b6fed07 to 9403b9c Compare March 27, 2026 09:49
@cert-manager-prow cert-manager-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 27, 2026
@maelvls maelvls force-pushed the cleanup-after-1.20-release branch from 9403b9c to f9e1160 Compare March 27, 2026 09:58
Copy link
Copy Markdown
Member

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@maelvls, you can self-approve. Just in case you want to bump the cert-manager version.

Comment thread prow/cert-manager_install.sh Outdated
@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2026
Copy link
Copy Markdown
Member

@wallrj-cyberark wallrj-cyberark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've compared this to the last two times I did this task (#1116 for 1.17, #1064 for 1.14). A few things stand out:

Outstanding fixes: The duplicate K8s version bug in otherKubernetesVersions (acknowledged in your reply to Copilot) and the v1.20.1 bump (suggested by Erik) haven't been pushed. The single commit is from March 27.

YAML reformatting noise in config.yaml: This PR reformats large sections of config.yaml — single quotes to double quotes, indentation changes throughout (branch-protection contexts, deck lenses, presets, tide queries). This is semantically equivalent YAML but makes the diff much noisier. In my #1116 and #1064, the config.yaml changes were limited to just removing the old branch's entries. Was the reformatting intentional (e.g. running a YAML formatter)? If so, splitting it into a separate commit would make the actual release-1.18 removal easier to verify.

K8s version matrix changes: My previous PRs (#1116, #1064) didn't change the K8s version matrix for remaining branches — they only removed the old branch. This PR also drops K8s 1.31/1.32 and changes the primary version for release-1.19. That's a bigger scope change; is it driven by K8s 1.31/1.32 going EOL, or something else? You mention it in the PR description, but it might be clearer as a separate PR or at least a separate commit.

Duplicate of #1168: Erik opened #1168 today doing the same 1.18 removal (without the K8s version changes or YAML reformatting). Should be closed in favour of this one.

What looks good: The core removal (specs.go, branch-protection, testgrid, job yaml deletion, cert-manager_install.sh bump) follows the same pattern as #1116.

Review conducted with assistance from Claude (Opus 4.6)

cert-manager 1.18 is no longer supported since the release of 1.20,
so removing all the testing configuration, as per the release process:
https://cert-manager.io/docs/contributing/release-process/#minor-releases

Changes:
- Remove release-1.18 from prowgen knownBranches
- Delete release-1.18 prow job spec and associated periodics
- Remove release-1.18 branch-protection entry
- Remove release-1.18 testgrid dashboard
- Bump cert-manager helm install version to v1.20.1
- Adjust cron schedules for release-1.19 and release-1.20 periodics;
  a side-effect of running `make prowgen`

Part of: cert-manager/cert-manager#8656

Co-Authored-By: Maël Valais <2195781+maelvls@users.noreply.github.com>
Co-Authored-By: Erik Godding Boye <1142578+erikgb@users.noreply.github.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Richard Wall <richard.wall@cyberark.com>
@wallrj-cyberark wallrj-cyberark force-pushed the cleanup-after-1.20-release branch from f9e1160 to e498f4d Compare April 11, 2026 12:04
@cert-manager-prow cert-manager-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2026
Copy link
Copy Markdown
Member

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maelvls (and @wallrj)!

/lgtm
/approve

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2026
@cert-manager-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2026
@cert-manager-prow cert-manager-prow bot merged commit c64b200 into master Apr 11, 2026
6 checks passed
@cert-manager-prow
Copy link
Copy Markdown
Contributor

@maelvls: Updated the following 2 configmaps:

  • job-config configmap in namespace default at cluster default using the following files:
    • key cert-manager-release-1.18.yaml using file ``
    • key cert-manager-release-1.19.yaml using file config/jobs/cert-manager/cert-manager/release-1.19/cert-manager-release-1.19.yaml
    • key cert-manager-release-1.20.yaml using file config/jobs/cert-manager/cert-manager/release-1.20/cert-manager-release-1.20.yaml
  • config configmap in namespace default at cluster default using the following files:
    • key config.yaml using file config/config.yaml
Details

In response to this:

cert-manager 1.18 is no longer supported since the release of 1.20, so removing all the testing configuration, as per the release process:

(final release only) Create a PR on cert-manager/testing, removing any unsupported release versions from prow config.

Changes:

  • Remove release-1.18 from prowgen knownBranches
  • Delete release-1.18 prow job spec and associated periodics
  • Remove release-1.18 branch-protection entry
  • Remove release-1.18 testgrid dashboard
  • Bump cert-manager helm install version to v1.20.1
  • Adjust cron schedules for release-1.19 and release-1.20 periodics; a side-effect of running make prowgen

Part of:

Based on:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wallrj-cyberark wallrj-cyberark deleted the cleanup-after-1.20-release branch April 11, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants