Skip to content

define env#1739

Merged
SFJohnson24 merged 3 commits into
mainfrom
define_env
May 20, 2026
Merged

define env#1739
SFJohnson24 merged 3 commits into
mainfrom
define_env

Conversation

@SFJohnson24
Copy link
Copy Markdown
Collaborator

@SFJohnson24 SFJohnson24 commented May 19, 2026 •
edited
Loading

  • updates env.example to .env.example; updated format
  • adds logic where if there is -dxp and -dep, checks if the define_xml is coming from the .env and if it is a complete path or a filename; if filename, uses the location of the .env to construct a path
  • update docs to reflect above behavior

@SFJohnson24 SFJohnson24 marked this pull request as draft May 19, 2026 19:17
@SFJohnson24 SFJohnson24 linked an issue May 20, 2026 that may be closed by this pull request
define-xml open rules #1740
Closed
@SFJohnson24 SFJohnson24 marked this pull request as ready for review May 20, 2026 13:13
@SFJohnson24 SFJohnson24 self-assigned this May 20, 2026
@SFJohnson24 SFJohnson24 removed a link to an issue May 20, 2026
define-xml open rules #1740
Closed
@SFJohnson24 SFJohnson24 linked an issue May 20, 2026 that may be closed by this pull request
define-xml open rules #1740
Closed
gerrycampion
gerrycampion approved these changes May 20, 2026
View reviewed changes
Comment thread core.py
if define_xml_path and dotenv_path and os.getenv("DEFINE_XML"):
dxp = Path(define_xml_path)
if not dxp.is_absolute() and dxp.parent == Path("."):
resolved = Path(dotenv_path).parent / define_xml_path
Copy link
Copy Markdown
Collaborator

@gerrycampion gerrycampion May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I didn't know path had this slash operator

@SFJohnson24 SFJohnson24 merged commit d6686aa into main May 20, 2026
11 checks passed
@SFJohnson24 SFJohnson24 deleted the define_env branch May 20, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gerrycampion gerrycampion gerrycampion approved these changes

@RamilCDISC RamilCDISC Awaiting requested review from RamilCDISC

Assignees

@SFJohnson24 SFJohnson24

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

define-xml open rules

2 participants

@SFJohnson24 @gerrycampion