common fixes for guava_version_upgrade#82
Open
AbhishekKumar9984 wants to merge 1 commit intocdapio:cs_guava_upgradefrom
Open
common fixes for guava_version_upgrade#82AbhishekKumar9984 wants to merge 1 commit intocdapio:cs_guava_upgradefrom
AbhishekKumar9984 wants to merge 1 commit intocdapio:cs_guava_upgradefrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request upgrades the Guava library to version 32.0.0-jre and refactors the codebase to replace deprecated or internal Guava utilities with standard Java APIs or modern Guava alternatives. Key changes include migrating from com.google.common.base.Charsets to java.nio.charset.StandardCharsets, replacing com.google.common.base.Objects with java.util.Objects or com.google.common.base.MoreObjects, and substituting Throwables.propagate with standard RuntimeException wrapping. Feedback suggests improving the ASM bytecode generation in FieldAccessorGenerator.java by using a more general exception type for local variables and simplifying the instruction sequence for exception instantiation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace removed APIs:
Throwables.propagate() -> throw new RuntimeException(e)
InputSupplier (removed) -> use existing ContentProvider
Charsets.UTF_8 -> StandardCharsets.UTF_8
Objects.toStringHelper/firstNonNull -> MoreObjects equivalents
Objects.hashCode -> java.util.Objects.hash
startAndWait/stopAndWait -> startAsync().awaitRunning/stopAsync().awaitTerminated
Update ASM bytecode generation to use RuntimeException constructor
Fix header ordering in HttpRequestsTestBase