Skip to content

bump contracts 3.0.0 alpha#779

Open
vfusco wants to merge 17 commits into
next/2.0from
feature/bump-contracts-3.0
Open

bump contracts 3.0.0 alpha#779
vfusco wants to merge 17 commits into
next/2.0from
feature/bump-contracts-3.0

Conversation

@vfusco
Copy link
Copy Markdown
Collaborator

@vfusco vfusco commented May 22, 2026

No description provided.

@vfusco vfusco added this to the 2.0.0 milestone May 22, 2026
@vfusco vfusco requested review from Copilot and mpolitzer May 22, 2026 23:29
@vfusco vfusco self-assigned this May 22, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

@vfusco vfusco force-pushed the feature/bump-contracts-3.0 branch from 9fe6817 to 29d3a22 Compare May 23, 2026 19:08
@vfusco vfusco force-pushed the feature/bump-contracts-3.0 branch 3 times, most recently from 3fd844d to 89141df Compare May 27, 2026 23:52
@vfusco vfusco marked this pull request as ready for review May 27, 2026 23:53
@vfusco vfusco requested a review from renatomaia May 27, 2026 23:53
// IApplicationFactory ABI so the encoding stays in lockstep with the
// contract definition. The tuple type is taken from
// `calculateApplicationAddress` (unique signature, no overload ambiguity).
var withdrawalConfigArgs = func() abi.Arguments {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never seen a panic in this context.

This is a theoretical question since we know the ABI is there in the source code, but it got me curious as to what would happen if this got triggered.

Would the panic happen during startup?

@vfusco vfusco force-pushed the feature/bump-contracts-3.0 branch from 89141df to f16b445 Compare May 29, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants