fix: activity name being ignored when starting live activity#116
Open
rshallam wants to merge 1 commit intocallstackincubator:mainfrom
Open
fix: activity name being ignored when starting live activity#116rshallam wants to merge 1 commit intocallstackincubator:mainfrom
rshallam wants to merge 1 commit intocallstackincubator:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #115
startLiveActivitywas sendingactivityIdas the bridge key, butStartVoltraOptionsdeclares@Field activityName. so the value was silently dropped — activities always got a random UUID insteadChanges
activityIdtoactivityNamein the TS bridge types and call sites so the key matches Swift.Test plan
npm test— unit tests pass (including correctedactivityName preservedtest)npm run build— type checking