refactor: P1 structural improvements — move interactors to core, consolidate selectors, rename client-shared

[thymikee]

Summary

Refines the P1 structural cleanup into smaller, more disposable modules with clearer ownership.

• Split selector internals into focused parse, match, and resolve modules while keeping src/daemon/selectors.ts as a thin facade.
• Split artifact handling back into cohesive responsibilities: download flow, archive handling, and upload receiving.
• Removed repeated CLI output plumbing by introducing shared command rendering helpers under src/cli/commands/.
• Kept iOS and macOS interaction behavior aligned while moving macOS screenshot surface routing behind the interactor interface instead of branching in core dispatch.
• Preserved the existing CLI and daemon behavior while reducing file size, platform leakage, and duplicated orchestration code.

Benefits

• Smaller modules are easier to review, move, or delete without dragging unrelated logic with them.
• Core dispatch is more platform-agnostic; platform-specific screenshot behavior now lives with the platform interactor.
• Selector and artifact code is easier to reason about because responsibilities are split by behavior, not just by file count.
• CLI commands share one rendering path instead of repeating the same JSON vs human-output branching.

Validation

• pnpm typecheck
• pnpm exec vitest run src/core/__tests__/dispatch-screenshot.test.ts src/__tests__/cli-client-commands.test.ts
• pnpm test:smoke
• pnpm test:unit

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[github-actions]

PR Preview Action v1.8.1
🚀 View preview at https://callstackincubator.github.io/agent-device/pr-preview/pr-314/
Built to branch gh-pages at 2026-03-28 18:26 UTC. Preview will be ready when the GitHub Pages deployment is complete.