🎨 Palette: Expand clickable area for cache selection rows#58
🎨 Palette: Expand clickable area for cache selection rows#58
Conversation
…ists * Wrap entire row content (`HStack`) in `Button` for `CategoryRow` and `NodeModulesRow`. * Apply `.contentShape(Rectangle())` to make empty spaces selectable. * Apply `.buttonStyle(.plain)` to preserve default text appearances. * Combine accessibility elements for cohesive VoiceOver experiences. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What
Wrapped the entire row content for
CategoryRowandNodeModulesRowin an outerButton, applying.contentShape(Rectangle())and.buttonStyle(.plain).🎯 Why
Previously, only the small checkbox icon itself was wrapped in a
Button. This resulted in a very tiny click target that forced users to click precisely on the icon rather than anywhere on the logical row, frustrating interactions and degrading overall UX. Expanding the hit target dramatically improves app usability and expected behavior on macOS.📸 Before/After
Before: Clicking anywhere outside the tiny checkbox icon did nothing. Screen readers fragmented the row readouts.
After: Clicking the text, icon, or blank space within the row's bounding box smoothly toggles the selection.
♿ Accessibility
Added
.accessibilityElement(children: .combine)so VoiceOver reads the row contents together cohesively instead of forcing users to individually step through internal text segments and button icons. The expanded hit area is also significantly more friendly for users with motor difficulties.PR created automatically by Jules for task 1473383829266846082 started by @acebytes