Skip to content

🎨 Palette: Expand clickable hit targets and improve VoiceOver in list rows#52

Open
acebytes wants to merge 1 commit intomainfrom
palette/ux-expand-hit-targets-16129611402811052332
Open

🎨 Palette: Expand clickable hit targets and improve VoiceOver in list rows#52
acebytes wants to merge 1 commit intomainfrom
palette/ux-expand-hit-targets-16129611402811052332

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

💡 What:
Wrapped the entire content of CategoryRow and NodeModulesRow in a Button rather than restricting the tap target to just the small checkbox image. Applied .contentShape(Rectangle()) so that empty space in the row registers taps, and .buttonStyle(.plain) to prevent unintended row-wide link styling.

🎯 Why:
The previous implementation required high precision to click the small checkbox to select or deselect a row. Now users can comfortably click anywhere on the row to toggle its state.

📸 Before/After:
Before: Only the 24x24 icon area was interactive.
After: The entire width of the row is interactive.

♿ Accessibility:
Added .accessibilityElement(children: .combine) to both row types. Previously, VoiceOver users had to navigate through fragmented text blocks (name, size, badge) to reach the checkbox toggle. Now, the row is announced as a single cohesive, interactive descriptive element.


PR created automatically by Jules for task 16129611402811052332 started by @acebytes

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant