Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix command injection in toolExists and remove bash wrappers#48

Open
acebytes wants to merge 1 commit intomainfrom
sentinel/fix-command-injection-process-2728279559680772638
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix command injection in toolExists and remove bash wrappers#48
acebytes wants to merge 1 commit intomainfrom
sentinel/fix-command-injection-process-2728279559680772638

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

🚨 Severity: HIGH
πŸ’‘ Vulnerability: toolExists in CacheCategory used string interpolation to execute a bash wrapper shell("/usr/bin/which \(tool)"). This introduces a severe command injection vector. Similarly, dockerPrune in CacheoutViewModel relied on a bash wrapper /bin/bash -c "docker system prune -f 2>&1", introducing unnecessary shell interpreters.
🎯 Impact: If toolExists were ever passed untrusted or malformed input, it could execute arbitrary commands on the host under the user's privilege context.
πŸ”§ Fix:

  • Replaced the bash wrapper shell() call in toolExists with a direct invocation of /usr/bin/which using Process(), placing the dynamic tool securely within the .arguments array to avoid shell expansion and string manipulation.
  • Hardened dockerPrune() to skip the bash wrapper by executing /usr/bin/env directly with ["docker", "system", "prune", "-f"] arguments, securely replacing the 2>&1 bash redirect by assigning both standardOutput and standardError to the same Pipe() instance.
    βœ… Verification: Verified syntax and process configuration via manual review. Environment does not currently support swift for local test execution.

PR created automatically by Jules for task 2728279559680772638 started by @acebytes

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant