C++: fix compile errors when lowering result<string>, etc.#1620
Merged
alexcrichton merged 2 commits intoMay 27, 2026
Conversation
Previously, the code generator got confused about when to use `wit::string` vs. `std::string_view` when lowering variants with string payloads, tuple-with-string payloads, etc. I'll admit my C++ skills are pretty out-of-date, so I'm not 100% confident I've got everything lined up correctly here, but it fixes the scenarios I've run into so far. Feedback from experts in modern C++ would be very welcome.
Collaborator
Author
|
Interesting; the Rust codegen is choking on the new test case. I'll investigate. |
Member
|
Feel free to ignore the Rust test failure if it takes too much to investigate, it's got to do with trying to get everything working in all borrowing modes which while useful isn't always the most urgent |
Collaborator
Author
|
Okay, I'll add it to the |
alexcrichton
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the code generator got confused about when to use
wit::stringvs.std::string_viewwhen lowering variants with string payloads, tuple-with-string payloads, etc.I'll admit my C++ skills are pretty out-of-date, so I'm not 100% confident I've got everything lined up correctly here, but it fixes the scenarios I've run into so far. Feedback from experts in modern C++ would be very welcome.