Skip to content

fix(plsql): add MAXSIZE option to STORAGE clause grammar #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
h3n4l merged 1 commit into from
Mar 24, 2026
Merged

fix(plsql): add MAXSIZE option to STORAGE clause grammar #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions plsql/PlSqlParser.g4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3769,6 +3769,7 @@ storage_clause
| FLASH_CACHE (KEEP | NONE | DEFAULT)
| CELL_FLASH_CACHE (KEEP | NONE | DEFAULT)
| ENCRYPT
| MAXSIZE (UNLIMITED | size_clause)
)+
RIGHT_PAREN
;
Expand Down
48 changes: 48 additions & 0 deletions plsql/examples/create_table.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,3 +394,51 @@ CREATE TABLE print_media_demo
NESTED TABLE ad_textdocs_ntab STORE AS nt_p2
)
TABLESPACE tbs_03;

CREATE TABLE RPT.NN_CN_Q384_B1_RSLT
(
TXN_DATE DATE,
ETL_DATE DATE,
ID_RSLT NUMBER,
CN_CAP1 VARCHAR2(100),
CN_CAP2 VARCHAR2(100),
TEN_CN VARCHAR2(4000),
TEN_PGD VARCHAR2(4000),
STT_AO NUMBER,
FORMAT_ROW VARCHAR2(50),
STT VARCHAR2(1000),
TEN_DV VARCHAR2(4000),
HDV NUMBER,
DUNO NUMBER,
BAO_LANH NUMBER,
LC NUMBER,
NOXAU NUMBER,
TL_NOXAU NUMBER
) ROW STORE COMPRESS ADVANCED
TABLESPACE ARCHIVE_TBS
PCTUSED 0
PCTFREE 10
INITRANS 1
MAXTRANS 255
STORAGE (
BUFFER_POOL DEFAULT
)
NOLOGGING
PARTITION BY RANGE (TXN_DATE)
INTERVAL (NUMTODSINTERVAL(1,'DAY'))
(
PARTITION PART_01 VALUES LESS THAN (TO_DATE(' 2012-01-01 00:00:00', 'SYYYY-MM-DD HH24:MI:SS', 'NLS_CALENDAR=GREGORIAN'))
NOLOGGING
ROW STORE COMPRESS ADVANCED
TABLESPACE ARCHIVE_TBS
PCTFREE 10
INITRANS 1
MAXTRANS 255
STORAGE (
INITIAL 8M
NEXT 1M
MAXSIZE UNLIMITED
MINEXTENTS 1
MAXEXTENTS UNLIMITED
BUFFER_POOL DEFAULT
));
Comment on lines +399 to +444
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change adds a large, production-like DDL statement into plsql/examples/create_table.sql. If this is intended primarily as a regression fixture for BYT-9088, consider moving it into a smaller, dedicated example/fixture file (e.g., plsql/examples/byt-9088.sql or a test-fixtures directory if one exists) to keep create_table.sql from growing into an unmanageable catch-all corpus.

Suggested change
(
TXN_DATE DATE,
ETL_DATE DATE,
ID_RSLT NUMBER,
CN_CAP1 VARCHAR2(100),
CN_CAP2 VARCHAR2(100),
TEN_CN VARCHAR2(4000),
TEN_PGD VARCHAR2(4000),
STT_AO NUMBER,
FORMAT_ROW VARCHAR2(50),
STT VARCHAR2(1000),
TEN_DV VARCHAR2(4000),
HDV NUMBER,
DUNO NUMBER,
BAO_LANH NUMBER,
LC NUMBER,
NOXAU NUMBER,
TL_NOXAU NUMBER
) ROW STORE COMPRESS ADVANCED
TABLESPACE ARCHIVE_TBS
PCTUSED 0
PCTFREE 10
INITRANS 1
MAXTRANS 255
STORAGE (
BUFFER_POOL DEFAULT
)
NOLOGGING
PARTITION BY RANGE (TXN_DATE)
INTERVAL (NUMTODSINTERVAL(1,'DAY'))
(
PARTITION PART_01 VALUES LESS THAN (TO_DATE(' 2012-01-01 00:00:00', 'SYYYY-MM-DD HH24:MI:SS', 'NLS_CALENDAR=GREGORIAN'))
NOLOGGING
ROW STORE COMPRESS ADVANCED
TABLESPACE ARCHIVE_TBS
PCTFREE 10
INITRANS 1
MAXTRANS 255
STORAGE (
INITIAL 8M
NEXT 1M
MAXSIZE UNLIMITED
MINEXTENTS 1
MAXEXTENTS UNLIMITED
BUFFER_POOL DEFAULT
));
-- BYT-9088 regression fixture:
-- The large, production-like partitioned table definition that was
-- previously in this generic example file has been moved to a
-- dedicated fixture (e.g., plsql/examples/byt-9088.sql) to keep
-- create_table.sql small and focused on simple examples.

Copilot uses AI. Check for mistakes.
Loading
Loading