Support portable KSP build paths#2
Draft
Sean-Kenneth-Doherty wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KSP_x64_Data/ManagedorKSP_Data/Managedfrom the configured KSP root.KSP_PATH,KSPDIR,KSP_DIR, or directKSPManagedDirbuild properties, with clear missing-reference errors.RunPostBuildCopy=falseand fix the checked-in AVC version file so it parses as strict JSON.Why
Current
masterhas already moved the plugin source and version metadata to KSP 1.12.x, but the project still assumes the WindowsKSP_x64_Datamanaged-assembly layout. That blocks a clean build against a normal Linux KSP 1.12.5 install, where the assemblies live underKSP_Data/Managed.The tracked
PAPIPluginContinued.versionalso has a trailing comma in theGITHUBblock, so strict JSON tooling rejects it.Scope / caveats
This is build-system and metadata cleanup only. It does not change plugin runtime behavior. The default post-build copy still uses the existing Windows
xcopycommand; Linux or compile-only builds should pass/p:RunPostBuildCopy=false. KSP was not launched and runway-light behavior was not tested.Validation
xbuild PAPIPlugin.sln /p:Configuration=Release /p:KSP_PATH="/path/to/Kerbal Space Program" /p:RunPostBuildCopy=false /verbosity:minimalagainst a local KSP 1.12.5.3190 install.xmllint --noout PAPIPlugin/PAPIPlugin.csprojjq empty assets/GameData/PAPIPlugin/PAPIPluginContinued.versiongit diff --check HEAD~1..HEAD