fix: handle provider status default cases across providers.#107
Open
garvitssoni wants to merge 3 commits intomainfrom
Open
fix: handle provider status default cases across providers.#107garvitssoni wants to merge 3 commits intomainfrom
garvitssoni wants to merge 3 commits intomainfrom
Conversation
stephahart
reviewed
Apr 9, 2026
v1/providers/fluidstack/instance.go
Outdated
| lifecycleStatus = v1.LifecycleStatusFailed | ||
| default: | ||
| lifecycleStatus = v1.LifecycleStatusPending | ||
| lifecycleStatus = "" |
Contributor
There was a problem hiding this comment.
Suggested change
| lifecycleStatus = "" | |
| lifecycleStatus = v1.LifecycleStatusEmpty |
Contributor
|
How do we handle the empty status in dev-plane and the UI? In these cases, does it make more sense to assume the instance is terminated rather than returning an empty status? |
garvitssoni
force-pushed
the
BREV-3225/deletion-stuck-at-deploying
branch
from
c0ff74d to
464b0c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Across several providers, unknown/transient status values were being coerced into concrete lifecycle states (commonly
pending). During deletion this led to incorrect “Starting/Deploying” signals and contributed to UI status regressions.Root cause
Default-case handling in provider status mappers treated unknown values as known states instead of surfacing “unknown.”
Fix
pending/failed.