add support for pushing sandboxes#72
Open
Nathan Selvidge (nselvidge) wants to merge 2 commits intomainfrom
Open
add support for pushing sandboxes#72Nathan Selvidge (nselvidge) wants to merge 2 commits intomainfrom
Nathan Selvidge (nselvidge) wants to merge 2 commits intomainfrom
Conversation
|
Latest downloadable build artifacts for this PR commit
Available artifact names
|
Parker Henderson (parkerhendo)
force-pushed
the
functions-push-pull-command
branch
from
a6b375c to
5f7d51f
Compare
Nathan Selvidge (nselvidge)
force-pushed
the
nate/sandbox-push
branch
2 times, most recently
from
1ff2094 to
309441c
Compare
Nathan Selvidge (nselvidge)
changed the base branch from
functions-push-pull-command
to
main
Nathan Selvidge (nselvidge)
force-pushed
the
nate/sandbox-push
branch
from
309441c to
8de1749
Compare
Nathan Selvidge (nselvidge)
requested a review
from Parker Henderson (parkerhendo)
Parker Henderson (parkerhendo)
approved these changes
Apr 3, 2026
Contributor
Parker Henderson (parkerhendo)
left a comment
Parker Henderson (parkerhendo)
left a comment
There was a problem hiding this comment.
Not blocking I don't think but one small note related to eval parameters
Comment on lines
+639
to
+643
| const serialized = toJsonValue(rawParams as JsonValue); | ||
| if (serialized !== undefined) { | ||
| evaluatorDefinition.parameters = serialized; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Can we reuse the existing evaluator-parameter serialization flow from eval-runner.ts here, instead of the direct toJsonValue(rawParams) path? I think using the shared serializer covers some cases with Zod->JSON Schema conversion that help avoid malformed evaluator_definition.parameters for parameterized evals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to push sandboxes using the
bt function pushcommand. pushes lambda sandboxes for each language.