Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions py/src/braintrust/contrib/temporal/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -421,21 +421,21 @@ def __init__(self, logger: Any | None = None) -> None:

params = inspect.signature(SimplePlugin.__init__).parameters

# temporalio >= 1.23.0 merged client_interceptors/worker_interceptors
# into a single `interceptors` parameter.
# temporalio plugin APIs differ by version. Newer releases may expose
# a merged `interceptors` kwarg, while older releases keep separate
# client/worker interceptor kwargs. Build kwargs dynamically so pylint
# does not validate unsupported keywords against the installed version.
kwargs: dict[str, Any] = {
"name": "braintrust",
"workflow_runner": _modify_workflow_runner,
}
if "interceptors" in params:
super().__init__( # pylint: disable=unexpected-keyword-arg
name="braintrust",
interceptors=[interceptor],
workflow_runner=_modify_workflow_runner,
)
kwargs["interceptors"] = [interceptor]
else:
super().__init__(
name="braintrust",
client_interceptors=[interceptor],
worker_interceptors=[interceptor],
workflow_runner=_modify_workflow_runner,
)
kwargs["client_interceptors"] = [interceptor]
kwargs["worker_interceptors"] = [interceptor]

super().__init__(**kwargs)


__all__ = ["BraintrustInterceptor", "BraintrustPlugin"]
8 changes: 7 additions & 1 deletion py/src/braintrust/wrappers/test_pydantic_ai_integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,13 @@ def _assert_metrics_are_valid(metrics, start, end):
assert "end" in metrics
assert "duration" in metrics
assert start <= metrics["start"] <= metrics["end"] <= end
assert metrics["duration"] > 0
assert metrics["duration"] >= 0
assert metrics["duration"] == pytest.approx(metrics["end"] - metrics["start"], abs=1e-9)

# Windows can report identical timestamps for very fast synchronous operations,
# so duration may legitimately be 0.0 for those spans.
if metrics["end"] > metrics["start"]:
assert metrics["duration"] > 0

# Token metrics (if present)
if "tokens" in metrics:
Expand Down
Loading