fix. errors of register login#47
Open
FBagdeli wants to merge 9 commits into
Open
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
|
||
| if(password.length < 1) return 'Password is required' | ||
| if(password.length < minLength ) return 'Password should be at least 8 characters long' | ||
| if(password.length > 24) return 'Password should be less than 24 characters' |
Collaborator
There was a problem hiding this comment.
Probably wait for the database changes, if this is required surely could be used, but for right now, i guess this is not supposed to be added.
MyrtheDullaart
requested changes
Jul 18, 2024
| const handleRegister = async (email, password, setErrors) => { | ||
| try { | ||
| const validatedEmail = validationEmail(email) | ||
| if(validatedEmail !== true) { |
Collaborator
There was a problem hiding this comment.
if(!validatedEmail)
| if(!hasUppercase) return 'Password should have at least one uppercase letter' | ||
| if(!hasNumber) return 'Password should have at least one number' | ||
| if(!hasSpecialCharacter) return 'Password should have at least one special character' | ||
| return 'ValidPassword' |
Collaborator
There was a problem hiding this comment.
I would return true or false for this function and just display 1 error message
| throw new Error(validatedEmail) | ||
| } | ||
| const validatedPassword = validationPassword(password) | ||
| if(validatedPassword !== 'ValidPassword') { |
Collaborator
There was a problem hiding this comment.
!validatedPassword
LeonardoSaraceli
requested changes
Jul 18, 2024
| if(!hasUppercase) return 'Password should have at least one uppercase letter' | ||
| if(!hasNumber) return 'Password should have at least one number' | ||
| if(!hasSpecialCharacter) return 'Password should have at least one special character' | ||
| return 'ValidPassword' |
LeonardoSaraceli
previously approved these changes
Jul 19, 2024
MyrtheDullaart
previously approved these changes
Jul 19, 2024
Auenc
suggested changes
Jul 19, 2024
|
|
||
| const handleLogin = async (email, password, setErrors) => { | ||
|
|
||
| const passwordRequirments = 'Password must be at least 8 characters long and include at least one uppercase letter, one number, and one special character.' |
There was a problem hiding this comment.
Let's put these errors in a utils/errors.js file so they're not scattered around the app
| const emailErrorMessage = "Please enter a valid email" | ||
|
|
||
| try { | ||
| const validatedEmail = validationEmail(email) |
| navigate("/verification") | ||
| } | ||
| const handleRegister = async (email, password, setErrors) => { | ||
| const passwordRequirments = 'Password must be at least 8 characters long and include at least one uppercase letter, one number, and one special character.' |
| const emailErrorMessage = "Please enter a valid email" | ||
|
|
||
| try { | ||
| const validatedEmail = validationEmail(email) |
| localStorage.setItem('token', token) | ||
| navigate('/') | ||
| } | ||
| // localStorage.setItem('token', token) |
| const onChange = (e) => { | ||
| const { name, value } = e.target; | ||
| setFormData({ ...formData, [name]: value }); | ||
| setErrors('') |
| @@ -38,10 +40,11 @@ const Login = () => { | |||
| label={"Password *"} | |||
There was a problem hiding this comment.
check the formatting here - it doesn't look right
| const { onRegister } = useAuth(); | ||
| const [formData, setFormData] = useState({ email: "", password: "" }); | ||
|
|
||
| const [errors, setErrors] = useState('') |
| const onChange = (e) => { | ||
| const { name, value } = e.target; | ||
| setFormData({ ...formData, [name]: value }); | ||
| setErrors('') |
| if(res.status === 'fail') { | ||
| throw new Error(res.data.error) | ||
| } | ||
| return await login(email, password) |
FBagdeli
dismissed stale reviews from MyrtheDullaart and LeonardoSaraceli
via
43bf1f9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.