frontend: views: ExtensionManagerView: center extension manager tabs#3869
Merged
patrickelectric merged 1 commit intoMay 5, 2026
Merged
Conversation
Reviewer's GuideCenters the Extension Manager tabs within the toolbar and keeps the Settings button aligned to the right via flexbox and responsive CSS adjustments. Flow diagram for ExtensionManagerView toolbar layout changesflowchart LR
ExtensionToolbar[ExtensionToolbar v_toolbar extension_toolbar] --> ExtensionTabs[ExtensionTabs v_tabs extension_tabs]
ExtensionToolbar --> SettingsButton[SettingsButton v_btn extension_toolbar_settings]
subgraph FlexLayout
ExtensionTabsFlex[extension_tabs flex 1_1_0 min_width 0]
SettingsButtonFlex[extension_toolbar_settings flex_shrink 0]
end
ExtensionTabs --> ExtensionTabsFlex
SettingsButton --> SettingsButtonFlex
subgraph DesktopMediaQuery min_width_900px
SettingsButtonPosition[extension_toolbar_settings position absolute right 16px top 50_percent translateY_minus_50_percent]
end
SettingsButtonFlex --> DesktopMediaQuery
DesktopMediaQuery --> SettingsButtonPosition
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The custom centering and right-align behavior for the toolbar could likely be expressed using Vuetify’s layout utilities (e.g.,
justify-center,v-spacer,class="ml-auto") instead of absolute positioning, which would simplify the CSS and reduce layout edge cases. - Consider replacing the hardcoded
@media (min-width: 900px)andright: 16pxbreakpoint/spacing values with existing design system or Vuetify breakpoint/spacing tokens so the layout stays consistent with the rest of the app’s responsive behavior.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The custom centering and right-align behavior for the toolbar could likely be expressed using Vuetify’s layout utilities (e.g., `justify-center`, `v-spacer`, `class="ml-auto"`) instead of absolute positioning, which would simplify the CSS and reduce layout edge cases.
- Consider replacing the hardcoded `@media (min-width: 900px)` and `right: 16px` breakpoint/spacing values with existing design system or Vuetify breakpoint/spacing tokens so the layout stays consistent with the rest of the app’s responsive behavior.
## Individual Comments
### Comment 1
<location path="core/frontend/src/views/ExtensionManagerView.vue" line_range="218-226" />
<code_context>
/>
- <v-toolbar>
- <v-spacer />
+ <v-toolbar class="extension-toolbar">
<v-tabs
v-model="tab"
</code_context>
<issue_to_address>
**issue (bug_risk):** Absolute positioning of the settings button may overlap the tabs without reserving horizontal space.
With `.extension-toolbar-settings` absolutely positioned, the tabs can extend underneath it because the toolbar no longer reserves horizontal space for the button. Around the breakpoint this can cause the settings icon to overlap tab labels or arrows.
Consider adding right padding or a max-width on `.extension-toolbar` (or similar layout change) so the tabs never render under the settings icon.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Collaborator
88ec517 to
4f694a2
Compare
patrickelectric
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

fix #2942
before:

zoomed-in:

after:

zoomed-in:

Summary by Sourcery
Center the extension manager tab bar while keeping the settings button consistently positioned.
Enhancements: