{183434696}: Use non-blocking for SSL client socket#5858
Merged
akshatsikarwar merged 2 commits intobloomberg:mainfrom Apr 14, 2026
Merged
{183434696}: Use non-blocking for SSL client socket#5858akshatsikarwar merged 2 commits intobloomberg:mainfrom
akshatsikarwar merged 2 commits intobloomberg:mainfrom
Conversation
riverszhang89
force-pushed
the
ssl_hang_v2
branch
from
1f73e77 to
247e286
Compare
roborivers
approved these changes
Apr 9, 2026
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
sp [db unavailable at finish]
cldeadlock
analyze **quarantined**
consumer_non_atomic_default_consumer_generated **quarantined**
api_tst
riverszhang89
force-pushed
the
ssl_hang_v2
branch
from
247e286 to
82e52e0
Compare
| _has_snapshot(clnt, resp); | ||
| _has_features(clnt, resp); | ||
| return newsql_response(clnt, &resp, 1); | ||
| if (debug_switch_stall_ssl_write()) { |
Contributor
There was a problem hiding this comment.
keep these inside COMDB2_TEST?
Contributor
Author
There was a problem hiding this comment.
Thanks Mohit ... I must've overlooked it here.
A partial write of an SSL encrypted block may cause the client to hang in SSL_read. Hence this patch uses non-blocking IO for SSL client sockets. Signed-off-by: Rivers Zhang <hzhang320@bloomberg.net>
riverszhang89
force-pushed
the
ssl_hang_v2
branch
from
82e52e0 to
4f6f948
Compare
roborivers
approved these changes
Apr 11, 2026
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
reco-ddlk-sql **quarantined**
consumer_non_atomic_default_consumer_generated **quarantined**
api_tst
alias
Signed-off-by: Akshat Sikarwar <asikarwar1@bloomberg.net>
akshatsikarwar
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A partial write of an SSL encrypted block may cause the client to hang in SSL_read. Hence this patch uses non-blocking IO for SSL client sockets.