fix scl leak on early schema change error#5855
Merged
dorinhogea merged 1 commit intobloomberg:mainfrom Apr 13, 2026
Merged
Conversation
If multitable_ddl is enabled, we need to check if the error code is resumable, and if not, we need to remove the sclist object. Signed-off-by: Dorin Hogea <dhogea@bloomberg.net>
mponomar
approved these changes
Apr 9, 2026
roborivers
approved these changes
Apr 9, 2026
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
scindex_logicalsc_generated [failed with core dumped]
consumer_non_atomic_default_consumer_generated **quarantined**
reco-ddlk-sql [timeout] **quarantined**
Contributor
Author
|
@mponomar thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an early schema hange error happens, schema change object is freed.
If multitable_ddl is enabled, we need to check if the error code is resumable, and if not, we need to remove the sclist object.