Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The darwin extractor (mmap writes, 8 workers, separate buffer pool) was written under the assumption that macOS needed a different extraction strategy. Benchmarking on a 16-core Mac with a 1.1 GB / 2.3 GB bundle shows both extractors perform identically: disk throughput is ~276 vs ~285 MB/s, well within noise, because download is always the bottleneck on macOS (home internet) and the zstd decoder has massive headroom (~4.2 GB/s).
This deletes
extract_darwin.go(203 lines) and removes the!darwinbuild tag fromextract_default.go, so the parallel extractor (16 small-file + 4 large-file workers) runs on all platforms.