MB-59670: GPU-Accelerated Vector Search#2236
Merged
CascadingRadium merged 46 commits intomasterfrom Apr 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds GPU acceleration support for vector field indexing and searching. The changes enable users to specify whether GPU should be used for vector operations through a new configuration field.
Key changes:
- Added
GPUboolean field toFieldMappingstruct for configuration - Extended vector field constructors to accept and store GPU parameter
- Added
GPU()getter method toVectorFieldfor accessing the GPU configuration
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| mapping/field.go | Added GPU boolean field to FieldMapping struct with JSON tag |
| mapping/mapping_vectors.go | Updated vector field creation to pass fm.GPU parameter |
| document/field_vector.go | Added gpu field to VectorField struct, updated constructors with GPU parameter, and added GPU() getter method |
| document/field_vector_base64.go | Updated NewVectorBase64Field constructor to accept and forward GPU parameter |
Comments suppressed due to low confidence (1)
document/field_vector_base64.go:163
- VectorBase64Field is missing a GPU() method to match the pattern of delegating VectorField interface methods. Since VectorBase64Field already exposes other VectorField methods like IndexOptimizedFor(), Similarity(), Dims(), and Vector(), it should also expose the GPU() method for API consistency. Add the following method after line 163:\n\n
go\nfunc (n *VectorBase64Field) GPU() bool {\n\treturn n.vectorField.GPU()\n}\n
func (n *VectorBase64Field) IndexOptimizedFor() string {
return n.vectorField.IndexOptimizedFor()
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
capemox
requested changes
Apr 13, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
capemox
previously approved these changes
Apr 16, 2026
Likith101
approved these changes
Apr 17, 2026
maneuvertomars
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gputo indicate whether the vector field must use GPUs for indexing/searching.