Open
Conversation
spatecon
approved these changes
Apr 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I'd like to be able to set the scorer of disjunction query to a custom one.
The reason is, that disjunction query scorer currently divides overall score of matched Disjuncts by the number of Disjuncts. Such behavior is reasonable for boolean query, but not for my use case (I need to get max score of Disjuncts). Unfortunately, the scorer is private property of a searcher.
To make it changeable, I renamed
DisjunctionScorer structtodisjunctionScorerand created aninterface DisjunctionScorerinstead. Then I addedfunc SetScorer(scorer scorer.DisjunctionQueryScorer)to disjunction searchers, which I use in my app.For consistency, I did similar changes to other scorers as well (not needed by me now).
Please see a proposal how such change could be done. I do not know the naming rules of bleve project well, no problem to change anything.
Best regards