Open
Conversation
fzhengbd
requested review from
bd-samratmuk,
devmehtabd,
dterrybd,
karolynbd,
shantyk and
zahidblackduck
dterrybd
approved these changes
Apr 9, 2026
devmehtabd
approved these changes
Apr 9, 2026
zahidblackduck
approved these changes
Apr 10, 2026
| // parentNode is the evicted node (guava:27.0) which is in evictedIds. | ||
| // The replacement (guava:30.1) is NOT in evictedIds, so legitimate edges | ||
| // like "guice" -> "guava:30.1" are preserved. | ||
| if (!evictedIds.contains(childNode) && !evictedIds.contains(parentNode)) { |
Collaborator
There was a problem hiding this comment.
We could use some small helper function like following for the two if conditionals on L47 and L57 as these checks are essentially the same,
private boolean shouldIncludeEdge(String childNode, String parentNode) {
return !evictedIds.contains(childNode) && !evictedIds.contains(parentNode);
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug
Eviction check only tested
childNodeagainstevictedIds, but the evicted node is theparentNodein the eviction edge, so the edge was never filtered.Fix
Added
!evictedIds.contains(parentNode)check to the condition in both single-root and multi-root branches.Also added the missing unit test
SbtGraphParserTransformerTest.Github Issues
N/A