[PM-32810] test: Cover Bank Account vault, listing, and search surfaces#6881
Conversation
SaintPatrck
added
the
ai-review-vnext
github-actions
Bot
added
app:password-manager
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This is a tightly scoped follow-up to #6877 that closes the Codecov gaps for the new Bank Account surfaces. New unit tests cover the Code Review DetailsNo findings. The PR is narrowly scoped, the tests exercise real branches in production code, the assertions match the production logic, and there are no security, correctness, or breaking-change concerns. |
Adds Bank Account coverage for the new branches introduced by the discovery work and applies @file:OmitFromCoverage to the affected navigation files so they are excluded from coverage at both file and class level — matching the convention used by other navigation files in the project. - SearchTypeDataExtensions: BankAccounts updateWithAdditionalDataIfNecessary and filterAndOrganize cases. - VaultItemListingStateExtensions: BankAccount toSearchType and toVaultItemCipherType cases. - VaultItemListingDataExtensions: BankAccount listing predicate, no-items state, and updateWithAdditionalDataIfNecessary cases.
SaintPatrck
force-pushed
the
new-item-types/PM-32810_bank-account-coverage
branch
from
13a3185 to
bf6dc81
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6881 +/- ##
==========================================
+ Coverage 85.72% 86.25% +0.53%
==========================================
Files 843 872 +29
Lines 60719 61571 +852
Branches 8915 8872 -43
==========================================
+ Hits 52049 53108 +1059
+ Misses 5606 5416 -190
+ Partials 3064 3047 -17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
🎟️ Tracking
PM-32810
Follow-up to #6877.
📔 Objective
Closes the Bank Account coverage gaps surfaced by Codecov on #6877. Adds test coverage for the new
BankAccountbranches in the Search and Item Listing utility extensions, and excludes the affected navigation files from coverage at both file and class level — matching the convention used by other navigation files in the project.SearchTypeDataExtensions: coversBankAccountsarms inupdateWithAdditionalDataIfNecessaryandfilterAndOrganize.VaultItemListingStateExtensions: coversBankAccountarms intoSearchType()andtoVaultItemCipherType().VaultItemListingDataExtensions: covers theBankAccountlisting predicate, no-items state (message, button, header), andupdateWithAdditionalDataIfNecessary.SearchNavigationandVaultItemListingNavigationannotated with@file:OmitFromCoverage.