Skip to content

[PM-36184] Update jira issue fetching process#6860

Merged
vvolkgang merged 1 commit into
mainfrom
vvolkgang/update-jira-release-notes
May 6, 2026
Merged

[PM-36184] Update jira issue fetching process#6860
vvolkgang merged 1 commit into
mainfrom
vvolkgang/update-jira-release-notes

Conversation

@vvolkgang
Copy link
Copy Markdown
Member

@vvolkgang vvolkgang commented Apr 30, 2026

🎟️ Tracking

PM-36184

📔 Objective

Note: copying changes from bitwarden/ios#2604

Use Jira's api url to retrieve jira notes, required by the new api key. While at it, refactored several bits we can use as a standard for future simple scripts:

  1. Replaced third-party http dependency with stdlib urllib, removing the need for uv and dependency version management.
  2. Introduced argparse to handle arguments and --help docs.
  3. Explicitly use python3 to call the script - we don't have a firm standard about this but it was LLM suggested as the most portable invocation across macOS and Ubuntu.

Test Run: https://github.com/bitwarden/android/actions/runs/25191637251

@vvolkgang vvolkgang added the ai-review-vnext Request a Claude code review using the vNext workflow label Apr 30, 2026
@github-actions github-actions Bot added the t:ci Change Type - Updates to automated workflows label Apr 30, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR updates the Jira release notes fetching script to use the new Atlassian API URL pattern (api.atlassian.com/ex/jira/{cloud_id}/...) required by the new API key, wires in the JIRA-CLOUD-ID secret from Azure Key Vault, replaces the requests third-party dependency with the stdlib urllib, and adopts argparse for argument parsing. The script also gains cloud-ID redaction in error output and the workflow invokes python3 explicitly. Changes mirror the previously reviewed iOS PR (bitwarden/ios#2604) and are validated by the linked test workflow run.

Code Review Details

No findings.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.54%. Comparing base (e6f0db6) to head (809ef5f).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6860      +/-   ##
==========================================
- Coverage   85.80%   85.54%   -0.27%     
==========================================
  Files         836      840       +4     
  Lines       59408    59731     +323     
  Branches     8672     8720      +48     
==========================================
+ Hits        50977    51096     +119     
- Misses       5442     5634     +192     
- Partials     2989     3001      +12     
Flag Coverage Δ
app-data 17.56% <ø> (+0.02%) ⬆️
app-ui-auth-tools 20.05% <ø> (-0.08%) ⬇️
app-ui-platform 15.79% <ø> (-0.07%) ⬇️
app-ui-vault 25.69% <ø> (+0.03%) ⬆️
authenticator 6.57% <ø> (-0.04%) ⬇️
lib-core-network-bridge 4.25% <ø> (-0.04%) ⬇️
lib-data-ui 1.02% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vvolkgang vvolkgang marked this pull request as ready for review April 30, 2026 22:07
@vvolkgang vvolkgang requested a review from a team as a code owner April 30, 2026 22:07
@vvolkgang vvolkgang removed the ai-review-vnext Request a Claude code review using the vNext workflow label May 5, 2026
@vvolkgang vvolkgang force-pushed the vvolkgang/update-jira-release-notes branch from 809ef5f to b4f1dee Compare May 5, 2026 13:04
@vvolkgang vvolkgang added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit 7fd63f7 May 6, 2026
46 of 47 checks passed
@vvolkgang vvolkgang deleted the vvolkgang/update-jira-release-notes branch May 6, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:ci Change Type - Updates to automated workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants