feat!: Add async support to persist_test_utils#343
Open
ValuedMammal wants to merge 3 commits intobitcoindevkit:masterfrom
Open
feat!: Add async support to persist_test_utils#343ValuedMammal wants to merge 3 commits intobitcoindevkit:masterfrom
persist_test_utils#343ValuedMammal wants to merge 3 commits intobitcoindevkit:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #343 +/- ##
=======================================
Coverage 80.21% 80.21%
=======================================
Files 24 24
Lines 5347 5347
Branches 242 242
=======================================
Hits 4289 4289
Misses 980 980
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ValuedMammal
force-pushed
the
feat/persist_test_utils_async
branch
2 times, most recently
from
15149b5 to
bf0057f
Compare
ValuedMammal
commented
Feb 19, 2026
ValuedMammal
force-pushed
the
feat/persist_test_utils_async
branch
2 times, most recently
from
7e53c18 to
8be4c86
Compare
ValuedMammal
force-pushed
the
feat/persist_test_utils_async
branch
from
8be4c86 to
2c011f1
Compare
ValuedMammal
changed the title
persist_test_utilspersist_test_utils
ValuedMammal
force-pushed
the
feat/persist_test_utils_async
branch
from
2c011f1 to
9c62a96
Compare
ValuedMammal
changed the title
persist_test_utilspersist_test_utils
ValuedMammal
force-pushed
the
feat/persist_test_utils_async
branch
2 times, most recently
from
940e7c1 to
8059762
Compare
ValuedMammal
force-pushed
the
feat/persist_test_utils_async
branch
from
8059762 to
12e1fcd
Compare
ValuedMammal
force-pushed
the
feat/persist_test_utils_async
branch
from
12e1fcd to
2d46064
Compare
Changed the definition of `persist_*` functions to take a `create_store` Fn (and no path) as the caller may want more control of the path to the database file. - deps: Make `tempfile`, `anyhow` dev-dependencies again
ValuedMammal
commented
Apr 16, 2026
ValuedMammal
force-pushed
the
feat/persist_test_utils_async
branch
from
2d46064 to
0547ea1
Compare
|
Concept ACK The sync side has 5 test utilities but only persist_wallet_changeset got an async equivalent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Expands the
persist_test_utilsmodule by adding a functionpersist_wallet_changeset_asyncto be used for testing anAsyncWalletPersisterimplementation.Changelog notice
Added
persist_wallet_changeset_asyncto persistence test suite for testing anAsyncWalletPersister.Changed
anyhow,tempfileChecklists
All Submissions:
New Features: